Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): add migration to remove skipTests from @schematics/angular:module #20849

Merged
merged 1 commit into from
May 19, 2021
Merged

fix(@schematics/angular): add migration to remove skipTests from @schematics/angular:module #20849

merged 1 commit into from
May 19, 2021

Conversation

alan-agius4
Copy link
Collaborator

Migration for #20842

Closes #20848

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label May 19, 2021
@alan-agius4 alan-agius4 requested a review from clydin May 19, 2021 13:33
@google-cla google-cla bot added the cla: yes label May 19, 2021
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 19, 2021
@alan-agius4 alan-agius4 merged commit 1080a52 into angular:master May 19, 2021
@alan-agius4 alan-agius4 deleted the skip-test-migration branch May 19, 2021 15:28
@jacekkoziol
Copy link

It seems like the issue still exists, I'm using:

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    
Angular CLI: 12.0.2
Node: 14.15.5
Package Manager: npm 6.14.11
OS: darwin x64

Angular: 12.0.2
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, language-service, platform-browser
... platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1200.2
@angular-devkit/build-angular   12.0.2
@angular-devkit/core            12.0.2
@angular-devkit/schematics      12.0.2
@schematics/angular             12.0.2
rxjs                            6.6.7
typescript                      4.2.4

And still get an error:

ng g module public

Schematic input does not validate against the Schema: {"skipTests":true,"path":"src/app","name":"public","project":"my-project-name"}
Errors:

  Data path "" must NOT have additional properties(skipTests).

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Jun 1, 2021

Have you updated using ng update?

You can run the migration by running the below command

ng update @angular/cli --migrate-only schematic-options-12

@jacekkoziol
Copy link

Yes, I've updated with ng update.
I've tried to use command:
ng update @angular/cli --migration-only schematic-options-12
and I'm getting the info:
Package '--migration-only' is not a dependency.

@alan-agius4
Copy link
Collaborator Author

Oops wrong command argument, fixed!

@jacekkoziol
Copy link

@alan-agius4 Thank you for your help! The command ng update @angular/cli --migrate-only schematic-options-12 solved the problem 😄

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schematic input does not validate against the Schema
3 participants