Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data path must NOT have additional properties(skipTests) #20842

Merged
merged 1 commit into from
May 19, 2021

Conversation

Patil2099
Copy link
Contributor

Fixes #20811

@google-cla google-cla bot added the cla: yes label May 19, 2021
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Can you please amend the commit message as per our guidelines highlighted in https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#-submitting-a-pull-request-pr

fix(@schematics/angular): don't add `skipTest` option to module schematic options

Closes ##20811

@Patil2099
Copy link
Contributor Author

Sure @alan-agius4

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 19, 2021
@Patil2099 Patil2099 requested a review from alan-agius4 May 19, 2021 06:30
@Patil2099
Copy link
Contributor Author

The commit message has been changed now @alan-agius4 .

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like now CI is failing due to formating.

Kindly run

  yarn ng-dev format files packages/schematics/angular/application/index.ts

Commit and squash and push again, thanks.

@Patil2099
Copy link
Contributor Author

I think this is complete now @alan-agius4. Please let me know if you want any other changes Thanks.

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 19, 2021
@alan-agius4 alan-agius4 mentioned this pull request May 19, 2021
@alan-agius4 alan-agius4 merged commit 36b5040 into angular:master May 19, 2021
alan-agius4 added a commit that referenced this pull request May 19, 2021
alan-agius4 added a commit that referenced this pull request May 19, 2021
…schematics/angular:module`

Migration for #20842

Closes #20848

(cherry picked from commit 1080a52)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data path "" must NOT have additional properties(skipTests). Angular 12.0.0
2 participants