-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data path must NOT have additional properties(skipTests) #20842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
Can you please amend the commit message as per our guidelines highlighted in https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#-submitting-a-pull-request-pr
fix(@schematics/angular): don't add `skipTest` option to module schematic options
Closes ##20811
Sure @alan-agius4 |
The commit message has been changed now @alan-agius4 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like now CI is failing due to formating.
Kindly run
yarn ng-dev format files packages/schematics/angular/application/index.ts
Commit and squash and push again, thanks.
…atic options Closes #angular#20811
I think this is complete now @alan-agius4. Please let me know if you want any other changes Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #20811