Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/silence sourcemap warnings for vendors #1673

Conversation

TheLarkInn
Copy link
Member

@TheLarkInn TheLarkInn commented Aug 12, 2016

Remove sourcemap for vendors if in prod, but in develop we will allow it. If a sourcemap isn't properly exposed/inlined (IE: @ngrx/core), the typical warning should be surpressed.

This will also result in faster prod builds

Fixes #1578

@filipesilva filipesilva merged commit 67098e0 into angular:master Aug 13, 2016
@TheLarkInn TheLarkInn deleted the feature/silence_sourcemap_warnings_for_vendors_and_only_pull_vendor_sourcemaps_in_develop_cause_why_need_them_for_prod branch August 15, 2016 13:37
@@ -19,5 +19,6 @@ export const webpackDevServerOutputOptions = {
hash: true,
timings: true,
chunks: false,
chunkModules: false
chunkModules: false,
warnings: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that going to remove all warnings? Is there a way to specifically remove source-maps warnings?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack -- typings issue with firebase
4 participants