Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excluding source maps with the new webpack mode #1575

Closed
DxCx opened this issue Aug 6, 2016 · 3 comments
Closed

excluding source maps with the new webpack mode #1575

DxCx opened this issue Aug 6, 2016 · 3 comments
Assignees

Comments

@DxCx
Copy link

DxCx commented Aug 6, 2016

Please provide us with the following information:

  1. OS? Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
    Linux (Arch)
  2. Versions. Please run ng --version. If there's nothing outputted, please run
    in a Terminal: node --version and paste the result here:
    angular-cli: 1.0.0-beta.11-webpack
    node: 6.3.1
    os: linux x64
  3. Repro steps. Was this an app that wasn't created using the CLI? What change did you
    do on your code? etc.
    this is abit tricky, i've found the issue because i've installed @ngrx/store,
    however, it is more general one.
    at the moment, with the new webpack mode, one cannot exclude sourcemaps,
    and not all node_modules have sourcemaps with them.
  4. The log given by the failure. Normally this include a stack trace and some
    more information.
    WARNING in .//@ngrx/router/hooks.js
    Cannot find source file '../../lib/hooks.ts': Error: Can't resolve '../../lib/hooks.ts' in '/home/hagai/a2z/gits/anipo/anipo-io/node_modules/@ngrx/router'
    @ ./
    /@ngrx/router/router-instruction.js 35:14-32
    @ ./~/@ngrx/router/index.js
    @ ./src/app/app.routes.ts
    @ ./src/main.ts
    @ multi main

WARNING in .//@ngrx/router/match-pattern.js
Cannot find source file '../../lib/match-pattern.ts': Error: Can't resolve '../../lib/match-pattern.ts' in '/home/hagai/a2z/gits/anipo/anipo-io/node_modules/@ngrx/router'
@ ./
/@ngrx/router/redirect.js 19:22-48
@ ./~/@ngrx/router/index.js
@ ./src/app/app.routes.ts
@ ./src/main.ts
@ multi main

WARNING in .//@ngrx/core/add/operator/enterZone.js
Cannot find source file '../../../../lib/add/operator/enterZone.ts': Error: Can't resolve '../../../../lib/add/operator/enterZone.ts' in '/home/hagai/a2z/gits/anipo/anipo-io/node_modules/@ngr
x/core/add/operator'
@ ./
/@ngrx/router/router-instruction.js 29:0-44
@ ./~/@ngrx/router/index.js
@ ./src/app/app.routes.ts
@ ./src/main.ts
@ multi main

WARNING in .//@ngrx/core/compose.js
Cannot find source file '../../lib/compose.ts': Error: Can't resolve '../../lib/compose.ts' in '/home/hagai/a2z/gits/anipo/anipo-io/node_modules/@ngrx/core'
@ ./
/@ngrx/store-log-monitor/json-tree/types.js 2:16-45
@ .//@ngrx/store-log-monitor/json-tree/json-tree.js
@ ./
/@ngrx/store-log-monitor/log-monitor/log-monitor-entry.js
@ .//@ngrx/store-log-monitor/log-monitor/log-monitor.js
@ ./
/@ngrx/store-log-monitor/store-log-monitor.js
@ ./~/@ngrx/store-log-monitor/index.js
@ ./src/main.ts
@ multi main

WARNING in .//@ngrx/core/operator/enterZone.js
Cannot find source file '../../../lib/operator/enterZone.ts': Error: Can't resolve '../../../lib/operator/enterZone.ts' in '/home/hagai/a2z/gits/anipo/anipo-io/node_modules/@ngrx/core/operato
r'
@ ./
/@ngrx/core/add/operator/enterZone.js 3:18-53
@ .//@ngrx/router/router-instruction.js
@ ./
/@ngrx/router/index.js
@ ./src/app/app.routes.ts
@ ./src/main.ts
@ multi main

  1. Mention any other details that might be useful.
    as i'm familiar with webpack, i was able to find the config quickly and make a W/O
    in models/webpack-build-common.ts file (getWebpackCommonConfig)
    i've added "path.resolve(projectRoot, 'node_modules/@ngrx'),"
    under loader source-map (line 32 here).

but i've opened the ticket because i think this is not proper,
the source map exclude should be controlled from the project itself.
(maybe add it to some config - not sure)


Thanks! We'll be in touch soon.

@TheLarkInn
Copy link
Member

Related to #1578.

@TheLarkInn TheLarkInn self-assigned this Aug 8, 2016
@hansl hansl closed this as completed Aug 8, 2016
@filipesilva
Copy link
Contributor

Fixed in #1673

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants