fix($state.transitionTo): trigger $stateChangeCancel appropriately #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2016
|
Good work! Can you update your PR so it doesn't change all the whitespace? |
|
Ah damn. Auto save hooks. On it. |
|
@christopherthielen Done! |
Current behaviour: We are in state A. We start a transition to state B. `$stateChangeStart` is triggered. Before `$stateChangeSuccess` is triggered for state B, we start a transition back to state A. No state events are triggered and we are left hanging without any notification. Updated behaviour: When the state change to B is superseded by the state change back to A, `$stateChangeCancel` is broadcasted on `$rootScope` for the transition from B -> A. This behaviour makes sure that for every `$stateChangeStart` there is a corresponding `$stateChange<Success|Error|Cancel>` thus completing the lifecycle. Fixes issue angular-ui#3027
zeusdeux
force-pushed
the
fix/transition-to-state-change-cancel
branch
from
6dc93a2 to
71b5b61
Compare
|
Hey @christopherthielen, do you think this PR is merge ready? I would love to have Thanks! |
|
I think it's probably good to merge, but I'd like to play with it for a little bit before releasing 0.3.2 |
|
@christopherthielen Sounds good. Do you have a time estimate in mind? It would be very useful for me to be able to communicate that to my team. |
|
I think #2696 should be fixed first, then I'm ready to release 0.3.2 |
|
@christopherthielen Could we get |
|
@zeusdeux released 0.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #3029
Current behaviour:
We are in state A. We start a transition to state B.
$stateChangeStartis triggered. Before
$stateChangeSuccessis triggered for state B, westart a transition back to state A. No state events are triggered and we
are left hanging without any notification.
Updated behaviour:
When the state change to B is superseded by the state change back to A,
$stateChangeCancelis broadcasted on$rootScopefor the transition fromB -> A. This behaviour makes sure that for every
$stateChangeStartthereis a corresponding
$stateChange<Success|Error|Cancel>thus completing thelifecycle.
Fixes issue #3027
PS: I have modified the existing test suite to assert on new behaviour