fix(ui-sref): handle state transition promise rejection #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeusdeux
force-pushed
the
fix/ui-sref-handle-failed-state-transition
branch
2 times, most recently
from
9658739 to
700a207
Compare
In the current world, ui-sref does nothing when the promise returned by $state.go is rejected. This PR gives ui-sref directive the ability to emit $stateChangeCancel when the transition promise rejects. The reason why I have chosen to implement this in the ui-sref directive and not in the definition for $state.go or $state.transitionTo are outlined in the issue below. angular-ui#3027.
zeusdeux
force-pushed
the
fix/ui-sref-handle-failed-state-transition
branch
from
700a207 to
3b6c735
Compare
|
@christopherthielen Agreed. Working on a patch for |
|
@christopherthielen Done here #3039. Please add that instead of this to 0.3.2 milestone. Closing this in favour of that. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current world,
ui-srefdoes nothing when the promise returned by$state.go is rejected. This PR gives
ui-srefdirective the ability toemit
$stateChangeCancelwhen the transition promise rejects.The reason why I have chosen to implement this in the
ui-srefdirectiveand not in the definition for $state.go or $state.transitionTo are
outlined in the issue below.
#3027