Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for interpolated ui-view names #1325

Closed
wants to merge 1 commit into from
Closed

Fix for interpolated ui-view names #1325

wants to merge 1 commit into from

Conversation

georeith
Copy link

@georeith georeith commented Sep 1, 2014

Fixes #1324

Allows scope variables to be used in the name attribute for a ui-view.
This allows ui-view to be used alongside directives such as ng-repeat.

Test results:

PhantomJS 1.9.7 (Mac OS X): Executed 220 of 220 SUCCESS (0.882 secs / 0.738 secs)

@christopherthielen
Copy link
Contributor

This PR is messy and doesn't conform to the contributor guidelines. That said, thanks for the legwork @georeith. I manually rewrote and merged it in via PR #1368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic view names broken 0.2.11
2 participants
@georeith @christopherthielen