Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic view names broken 0.2.11 #1324

Closed
georeith opened this issue Sep 1, 2014 · 1 comment · Fixed by #1368
Closed

Dynamic view names broken 0.2.11 #1324

georeith opened this issue Sep 1, 2014 · 1 comment · Fixed by #1368
Assignees
Labels
Milestone

Comments

@georeith
Copy link

georeith commented Sep 1, 2014

Dynamic view names are broken in 0.2.11, they work on the first loaded view but not on transitions. This means ng-repeat is no longer usable alongside ui-view.

The issue I believe is due to it now retrieving the name from getUiViewName() instead of data('$uiViewName).

See: e13988b#diff-6cb730f69dba1573a17c5532e05120eeL206

Examples

Working example in 0.2.10: http://plnkr.co/edit/HIt4QCUe1KCCO5kTEHYA?p=preview
Broken example in 0.2.11: http://plnkr.co/edit/uPPAUFIZfSQbKrrFsTmI?p=preview

Note

Logging out the name in 0.2.10 contains the evaluated expression.
Logging out the name in 0.2.11 contains the non-evaluated expression for anything but the first compilation.

@lemkepf
Copy link

lemkepf commented Oct 27, 2014

+1 Thanks for the fix on this! I was pounding my head on a wall for a whole day before I found this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants