Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to disable html5Mode with angular 1.3.0-rc.3 #1397

Closed
Yoshix opened this issue Sep 24, 2014 · 10 comments
Closed

Impossible to disable html5Mode with angular 1.3.0-rc.3 #1397

Yoshix opened this issue Sep 24, 2014 · 10 comments
Labels
Milestone

Comments

@Yoshix
Copy link

Yoshix commented Sep 24, 2014

Due to:

angular/angular.js@dc3de7f

the html5mode-check in urlRouter.js [line 383] is no longer correct. And thus it's impossible to disable html5mode.

A quick fix could be:

var isHtml5 = $locationProvider.html5Mode();
if (angular.isObject(isHtml5)) {
  isHtml5 = isHtml5.enabled;
}
@nateabele nateabele added the bug label Sep 24, 2014
@randallmeeker
Copy link

will this only effect people using html5mode or everyone use ui-router with angular1.3.0-rc3?

@Yoshix
Copy link
Author

Yoshix commented Sep 24, 2014

It's more the other way around. It will primarily affect those who don't want to use the html5mode. Because as it stands, one cannot disable it.

@pranaydutta89
Copy link

+1

@Yoshix Yoshix changed the title html5Mode broken with angular 1.3.0-rc.3 can't disable html5Mode with angular 1.3.0-rc.3 Sep 25, 2014
@Yoshix Yoshix changed the title can't disable html5Mode with angular 1.3.0-rc.3 Impossible to disable html5Mode with angular 1.3.0-rc.3 Sep 25, 2014
@coma
Copy link
Contributor

coma commented Sep 25, 2014

+1
Thanks @Yoshix, I was pulling my hair out because of this

@dduft
Copy link

dduft commented Sep 25, 2014

+1

@pensierinmusica
Copy link

+1 This was driving me crazy...

@christopherthielen
Copy link
Contributor

this is in tag 0.2.12-pre1

@RobbieTheWagner
Copy link

I'm on Angular 1.4.4 and seeing issues with html5mode again. Anyone else?

@winnemucca
Copy link

Yeah,
I am seeing the same issue. Let me know if you found a fix

@RobbieTheWagner
Copy link

@winnemucca I believe the issue should be fixed now. Are you on the latest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants