This repository has been archived by the owner on May 29, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(typeahead): add 'is-toggled' option #4779
Closed
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -588,6 +588,78 @@ describe('typeahead tests', function() { | |
}); | ||
}); | ||
|
||
describe('is-toggle indicator', function () { | ||
var element; | ||
|
||
beforeEach(function () { | ||
element = prepareInputEl('<div><input ng-model="result" uib-typeahead="item for item in source | filter:$viewValue" typeahead-is-toggled="isToggled"></div>'); | ||
}); | ||
|
||
it('should bind is-toggled indicator as true when matches are returned', function () { | ||
expect($scope.isToggled).toBeFalsy(); | ||
changeInputValueTo(element, 'b'); | ||
expect($scope.isToggled).toBeTruthy(); | ||
}); | ||
|
||
it('should bind is-toggled indicator as false when no matches returned', function () { | ||
expect($scope.isToggled).toBeFalsy(); | ||
changeInputValueTo(element, 'b'); | ||
expect($scope.isToggled).toBeTruthy(); | ||
changeInputValueTo(element, 'not match'); | ||
expect($scope.isToggled).toBeFalsy(); | ||
}); | ||
|
||
it('should bind is-toggled indicator as false when a match is clicked', function () { | ||
expect($scope.isToggled).toBeFalsy(); | ||
changeInputValueTo(element, 'b'); | ||
expect($scope.isToggled).toBeTruthy(); | ||
var match = $(findMatches(element)[1]).find('a')[0]; | ||
|
||
$(match).click(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given the above change, should be able to do just |
||
$scope.$digest(); | ||
expect($scope.isToggled).toBeFalsy(); | ||
}); | ||
it('should bind is-toggled indicator as false when click outside', function () { | ||
expect($scope.isToggled).toBeFalsy(); | ||
changeInputValueTo(element, 'b'); | ||
expect($scope.isToggled).toBeTruthy(); | ||
$document.find('body').click(); | ||
$scope.$digest(); | ||
expect($scope.isToggled).toBeFalsy(); | ||
}); | ||
|
||
it('should bind is-toggled indicator as false on enter', function () { | ||
expect($scope.isToggled).toBeFalsy(); | ||
changeInputValueTo(element, 'b'); | ||
expect($scope.isToggled).toBeTruthy(); | ||
triggerKeyDown(element, 13); | ||
expect($scope.isToggled).toBeFalsy(); | ||
}); | ||
|
||
it('should bind is-toggled indicator as false on tab', function () { | ||
expect($scope.isToggled).toBeFalsy(); | ||
changeInputValueTo(element, 'b'); | ||
expect($scope.isToggled).toBeTruthy(); | ||
triggerKeyDown(element, 9); | ||
expect($scope.isToggled).toBeFalsy(); | ||
}); | ||
|
||
it('should bind is-toggled indicator as false on escape key', function () { | ||
expect($scope.isToggled).toBeFalsy(); | ||
changeInputValueTo(element, 'b'); | ||
expect($scope.isToggled).toBeTruthy(); | ||
triggerKeyDown(element, 27); | ||
expect($scope.isToggled).toBeFalsy(); | ||
}); | ||
|
||
it('should bind is-toggled indicator as false input value smaller than a defined threshold', function () { | ||
var element = prepareInputEl('<div><input ng-model="result" uib-typeahead="item for item in source | filter:$viewValue" typeahead-is-toggled="isToggled" typeahead-min-length="2"></div>'); | ||
expect($scope.isToggled).toBeFalsy(); | ||
changeInputValueTo(element, 'b'); | ||
expect($scope.isToggled).toBeFalsy(); | ||
}); | ||
}); | ||
|
||
describe('pop-up interaction', function() { | ||
var element; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to do
var match = findMatches(element).find('a').eq(0)