feat(typeahead): add 'is-toggled' option #4779
Conversation
|
@chenyuzhcy I'm assuming you are adding a feature to indicate whether the typeahead dropdown is open or not? In all the other directives that offer this feature we have been using 'is-open', so for consistency sake, could we name this the same? |
| expect($scope.isToggled).toBeFalsy(); | ||
| changeInputValueTo(element, 'b'); | ||
| expect($scope.isToggled).toBeTruthy(); | ||
| var match = $(findMatches(element)[1]).find('a')[0]; |
There was a problem hiding this comment.
Better to do var match = findMatches(element).find('a').eq(0)
|
This LGTM, and I'm fine merging while making the changes as merging - any objections here? |
|
@RobJacobs I had the same idea at first but then I looked all the 'is-open' in the other directives, it all does toggle to the dropdown, but this is only an indicator of open or not (it does not manually open the dropdown even we set it to true) so I chose the name that's mentioned in the issue. But if you still insist 'is-open' is a better name I can change it very quickly. |
|
I think |
This is related to issue #4760