This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(timepicker): add seconds support #3022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the status of this feature change? Any plans to release it? |
|
+1 |
| @@ -27,7 +27,7 @@ exclude = [ | |||
| // - Safari | |||
| // - PhantomJS | |||
| browsers = [ | |||
| 'Chrome' | |||
|
The directive should default to the current behavior, but allow for optional overriding via a config object at the directive level. In the directive's isolate scope, we could have scope: {
config: '=?'
}
And if it is present, use it to override the default options. |
cgat
added a commit
to cgat/bootstrap
that referenced
this pull request
Aug 25, 2015
rdinicut made a PR (angular-ui#3022) for this, which was never merged. I've changed showSeconds to default to false and merged with current master. Conflicts: karma.conf.js src/timepicker/test/timepicker.spec.js src/timepicker/timepicker.js template/timepicker/timepicker.html
|
Let's continue in #4272 |
cgat
added a commit
to cgat/bootstrap
that referenced
this pull request
Oct 25, 2015
rdinicut made a PR (angular-ui#3022) for this, which was never merged. I've changed showSeconds to default to false and merged with current master.
cgat
added a commit
to cgat/bootstrap
that referenced
this pull request
Oct 25, 2015
rdinicut made a PR (angular-ui#3022) for this, which was never merged. I've changed showSeconds to default to false and merged with current master.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.