Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(timepicker): added support for seconds #2467

Closed
wants to merge 1 commit into from

Conversation

papoola
Copy link

@papoola papoola commented Jul 15, 2014

timpicker can now show seconds as well which is by default hidden. passing timepickerConfig.showSeconds=true or <timepicker show-seconds="true" ...> will enable this feature. Additional tests and documentation is still missing, and thats why I call to volunteers to help with adding tests and documentation particularly in #2326 #1763 #1231

@nyothecat
Copy link

Sorry to ask after your commit but did you add milliseconds as well? I am building an app sports lap times and would really need this.
Also, thanks for the seconds!

@CoolCriSyS
Copy link

What happened to this change? I don't see the showSeconds attr in the latest src?

@papoola
Copy link
Author

papoola commented Dec 5, 2014

@CoolCriSyS unfortunately no volunteers showed up to write test spec and I was my self too busy. Good news is that some one else has created a similar ( but more complete ) PR here #3022 so we just need to wait until it is accepted and merged into master

@nyothecat I am sorry, unfortunately milliseconds is not added and it shouldnt be that hard to add it if you really need it, but you need to find someone or do it your self

@Foxandxss
Copy link
Contributor

Seems like we have modern implementations to this, sorry for the delay.

Closing this.

@Foxandxss Foxandxss closed this Oct 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants