Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(app:client:coffee) client-side cleanup of .coffee files #351

Merged
merged 1 commit into from
Jul 17, 2014

Conversation

meeDamian
Copy link
Contributor

Changes include:

  • redundant parentheses and commas removed,
  • .bind(this) replaced with =>,
  • added function checks to all callbacks (vel. callback? value); It may be replaced by (callback=angular.noop) -> if that makes more sense(?),
  • all cb's renamed to callback (I'd prefer cb, but callback seems more verbose),
  • some new lines added to improve readability,
  • consistency fixes:
    • .{config,controller,factory,directive,run} now are always consistently in a new line,
    • all method calls are now on the same indentation level as their object.

@DaftMonk
Copy link
Member

Could you update the commit message to use the same style you use for the title of this issue?

@meeDamian
Copy link
Contributor Author

Done :)

@meeDamian
Copy link
Contributor Author

Apparently changing commit message was enough for travis to be happy again :-)

DaftMonk added a commit that referenced this pull request Jul 17, 2014
style(app:client:coffee) client-side cleanup of .coffee files
@DaftMonk DaftMonk merged commit 71f80ce into angular-fullstack:master Jul 17, 2014
@meeDamian meeDamian deleted the client-coffee-clenup branch July 17, 2014 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants