style(templates:coffee): cleanup & consistency fix of .coffee files #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-committed with missing spaces. |
| @@ -1,4 +1,5 @@ | |||
| 'use strict' | |||
|
|
|||
| angular.module('<%= scriptAppName %>').service '<%= classedName %>', <%= classedName %> = -> | |||
| angular.module '<%= scriptAppName %>' | |||
| .service '<%= classedName %>', <%= classedName %> = -> | |||
There was a problem hiding this comment.
@DaftMonk Any particular reason why we need to "name" function in a second parameter?
This regards to JS version as well:
angular.module('<%= scriptAppName %>')
.service('<%= classedName %>', function <%= IS_THIS_NAME_NEEDED? %>() {
// AngularJS will instantiate a singleton by calling "new" on this function
});
There was a problem hiding this comment.
Yeah, actually that second name isn't really necessary.
There was a problem hiding this comment.
Also we should change that to use cameledName name rather than classedName.
DaftMonk
added a commit
that referenced
this pull request
Jul 20, 2014
style(templates:coffee): cleanup & consistency fix of .coffee files
|
Oh bummer, just pushed new version with removed unnecessary function naming and fixed to |
|
I think that will have to be in a separate PR, :-/ sorry about that. |
|
No prob :). I'll push later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style fixes to match better with this
Changes include: