Test against newest TS versions #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading plugins by path is blocked in newer TS versions for security reasons. Convert the test plugins to packages and install them locally so we can include them in the tsconfig by name.
Moved fake plugin packages and various typescript versions to a package.json in the workspace. This is installed before running tests and means we can also include the main plugin by name
Newer versions of TS only allow plugins to be specified by package name. Dropped the tests and the code for guessing when the plugin is included via a local path. This will make no difference to anyone using the plugin normally via npm, and won't make any difference to properly set up projects.
Since we cannot load the plugin by filepath in newer TS versions, and we can't alias a package from a local path, it's hard to install the plugin with a different name and generate warnings in the tests. Added it awkwardly as a new name todo this.
Moved the default TS dependency to the project root to work around issues with packages that have peer deps being installed as local folders. Adjusted stored paths to compensate. Included TS as a peer dep for the dummy plugins that need it.
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS 3.9 as well as 4.0 and 4.2.
Due to microsoft/TypeScript#42712 this means a bunch of changes to tests to avoid loading the plugins as local names.
This also changes the order warnings slightly so that we only find the plugin by exact package name now. So warnings will no longer be shown if the plugin is used in the wrong order via a local path or an alias.