Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow package names for plugin names #42712

Closed
DanielRosenwasser opened this issue Feb 9, 2021 · 1 comment · Fixed by #42713
Closed

Only allow package names for plugin names #42712

DanielRosenwasser opened this issue Feb 9, 2021 · 1 comment · Fixed by #42713
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue

Comments

@DanielRosenwasser
Copy link
Member

We will need to only allow package names for loaded editor plugin names, to mitigate issues described in https://msrc.microsoft.com/update-guide/vulnerability/CVE-2021-1639

We'll be porting this to the following TypeScript versions:

  • 3.1.7
  • 3.7.6
  • 3.9.8
  • 4.0.6
  • 4.1.4
  • 4.2+
@danielwhite-aws
Copy link

This may have broken VSCode: microsoft/vscode#116229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants