Add a way to set PlayerControlView fullscreen button state #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oceanjules
reviewed
Sep 3, 2024
libraries/ui/src/main/java/androidx/media3/ui/PlayerControlView.java
Outdated
Show resolved
Hide resolved
libraries/ui/src/main/java/androidx/media3/ui/PlayerControlView.java
Outdated
Show resolved
Hide resolved
oceanjules
reviewed
Sep 10, 2024
libraries/ui/src/main/java/androidx/media3/ui/PlayerControlView.java
Outdated
Show resolved
Hide resolved
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
oceanjules
force-pushed
the
main
branch
3 times, most recently
from
9a52eb8
to
657aa4b
Compare
…r [minimalFullScreenButton] in PlayerView calling PlayerControlView
- Replaced all occurrences of "FullScreen" to "Fullscreen"
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1590.
I added and documented the new public-facing methods, moved some code to a new private method and used it to not duplicate code.