Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the developer to set the default state of isFullscreen #1590

Closed
theskyblockman opened this issue Aug 2, 2024 · 2 comments
Closed
Assignees

Comments

@theskyblockman
Copy link

Use case description

When multiple video players views are chained, if the user presses the fullscreen button in the PlayerControlView (the state of the button would go from fullScreenButton to minimalFullScreenButton) and then navigates to a second PlayerControlView while still being in fullscreen, the button will be in its default position (fullScreenButton) in this new PlayerControlView.

Proposed solution

Create a public facing method in PlayerView called setIsFullscreen which would call PlayerControlView.updateFullScreenButtonForState with the new state (also add the corresponding fullScreenButton and would update isFullscreen)

@icbaker
Copy link
Collaborator

icbaker commented Aug 2, 2024

This is the same request as google/ExoPlayer#10391, which I will dupe here.

@4brunu
Copy link

4brunu commented Aug 20, 2024

I have the same need, the problem is different but the solution would be the same.
I use a dialog to present the video in fullscreen.
If I use the player fullscreen button to enter and exit fullscreen, everything works as expected.
But if I'm in fullscreen and press back, the video exits fullscreen, but the fullscreen button stays out of sync.
Which means that I need to press it twice to enter in fullscreen mode again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants