-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the Issue in utis.py
#52
base: main
Are you sure you want to change the base?
Conversation
Generally these changes look ok, @cicada0007, but the tests are failing as you can see. I think that one of your changes isn't valid as 18 tests are now failing. Could you take a look at this and get back to me when you have an idea of what's wrong? Or would you prefer that I look into this? Thanks again! |
hey @andrewtavis Thank you noticing the error I will look into it |
Thank you for checking this, @cicada0007! |
hi @andrewtavis |
@cicada0007, can you let me know what your Python version is? I'm thinking I'm going to update kwx to run on 3.8+ :) I might just merge this as the changes do look good, and then I can figure out the conflicts on my end. |
@andrewtavis My current version of python is |
Thank you, @cicada0007. I figured as much :) |
If you have interest in helping with the update, then let me know. I did an initial update and test last night and to be expected there are lots of failures, but it seems like what needs to happen is that the test targets needs to be switched as the random seeds are behaving differently at this point :) So when we’re checking that the output of a model is a list of strings that’s always the same, it now needs to be different ones given that the random number generator behind the output is slightly different :) |
Ya that's correct |
Ok, @cicada0007 :) As I said I’ll merge this soon and try to figure the updates out. |
1 st changes
spacy_version
variable is used to store the version of theSpaCy
library. Inside the loop, the code checks whether theSpaCy
version is 3.0.0 or higher. If it is, the lemmatization is performed usingnlp(combined_texts)
. Otherwise, for older versions, the lemmatization is done usingnlp.tokenizer(combined_texts)
. This change accounts for potential differences inSpaCy
versions and ensures the code can handle them correctly.2 nd changes