Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit spaCy loading based on version #47

Open
andrewtavis opened this issue Mar 11, 2022 · 2 comments
Open

Edit spaCy loading based on version #47

andrewtavis opened this issue Mar 11, 2022 · 2 comments
Assignees
@cicada0007
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@andrewtavis
Copy link
Owner

spaCy has new loading mechanisms in the later versions that produce errors in data preparation within kwx.utils. The scripts should be changed to check the spaCy version so that these changes are accounted for and errors are produced.
@andrewtavis andrewtavis added bug Something isn't working good first issue Good for newcomers labels Mar 11, 2022
@cicada0007 cicada0007 mentioned this issue Jul 3, 2023
Open
@cicada0007
Copy link

Hi @andrewtavis 👋

I have gone through the utils.py and changed as you suggested
Thank you

@andrewtavis
Copy link
Owner Author

Thank you, @cicada0007! I’ll get to reviewing this later in the week :) First glances look good though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cicada0007 cicada0007

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewtavis @cicada0007