Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix proxy crash #514

Closed
andrewgazelka opened this issue Oct 25, 2024 — with Linear · 1 comment
Closed

fix proxy crash #514

andrewgazelka opened this issue Oct 25, 2024 — with Linear · 1 comment

Comments

@andrewgazelka Linear
Copy link
Owner 

thread 'tokio-runtime-worker' panicked at crates/hyperion-proxy/src/server_sender.rs:51:68:
called `Result::unwrap()` on an `Err` value: Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fish: Job 1, 'cargo run --profile release-ful…' terminated by signal SIGABRT (Abort)
@andrewgazelka andrewgazelka added the Bug label Oct 25, 2024 — with Linear
@linear Linear
Copy link

linear bot commented Oct 25, 2024

HYP-48 fix proxy crash

andrewgazelka added a commit that referenced this issue Oct 31, 2024
@andrewgazelka
fix: #514
bf9594a
andrewgazelka added a commit that referenced this issue Oct 31, 2024
@andrewgazelka
fix: handle player disconnection gracefully
24fe7bf 
Add error handling for when a player disconnects to prevent proxy crashes:
- Handle errors when sending player connect/disconnect events
- Handle broken pipe errors when player connection closes
- Add warning logs for failed message delivery

This prevents the proxy from crashing when a player's connection is terminated.
Fixes #514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewgazelka