EuiSuggestItems tests pass #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
commented
Jul 3, 2019
| @@ -77,7 +77,7 @@ export const SuggestItemExample = { | |||
| ], | |||
| text: ( | |||
| <p> | |||
| By default <EuiCode>EuiSuggestItem</EuiCode>'s{' '} | |||
| By default <EuiCode>EuiSuggestItem</EuiCode>'s{' '} | |||
There was a problem hiding this comment.
Writing text in the docs is weird sometimes. This just uses the unicode code for apostrophe so we don't have to escape it.
thompsongl
commented
Jul 3, 2019
| @@ -69,7 +69,8 @@ $buttonTypes: ( | |||
| } | |||
| } | |||
|
|
|||
| .euiSuggestItem__description, .euiSuggestItem__label { | |||
| .euiSuggestItem__description, | |||
| .euiSuggestItem__label { | |||
There was a problem hiding this comment.
Our linter wants each selector on its own line
thompsongl
commented
Jul 3, 2019
| @@ -1,9 +1,7 @@ | |||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | |||
There was a problem hiding this comment.
No need for TypeScript things yet. I'll help you convert when the time comes.
thompsongl
commented
Jul 3, 2019
| type: PropTypes.shape({ | ||
| icon: IconPropType, | ||
| color: PropTypes.oneOfType([PropTypes.oneOf(COLORS), PropTypes.string]), | ||
| }).isRequired, |
There was a problem hiding this comment.
Being more specific about what type wants, and making it required so it's always available. We can provide default values if that seems more like how people will use it.
thompsongl
commented
Jul 3, 2019
| @@ -4,9 +4,14 @@ import { requiredProps } from '../../test/required_props'; | |||
|
|
|||
| import { EuiSuggestItem } from './suggest_item'; | |||
|
|
|||
| const TYPE = { | |||
There was a problem hiding this comment.
Because we made type required, we need to add it to the test so it doesn't fail.
andreadelrio
added a commit
that referenced
this pull request
Jul 15, 2019
EuiSuggestItems tests pass
andreadelrio
pushed a commit
that referenced
this pull request
Aug 28, 2019
Update defazio fork to 13.0
andreadelrio
pushed a commit
that referenced
this pull request
Feb 24, 2020
* removed duplicate icons * Fixing changelog and updating tests (#1) Co-authored-by: Caroline Horn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple linting things and one React thing to make sure
EuiSuggestItemis always provided the data it expects (type)