Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate icons #2217

Closed
nreese opened this issue Aug 9, 2019 · 5 comments · Fixed by #2908
Closed

duplicate icons #2217

nreese opened this issue Aug 9, 2019 · 5 comments · Fixed by #2908
Labels
good first issue

Comments

@nreese
Copy link
Contributor

nreese commented Aug 9, 2019 •
edited
Loading

I noticed that some of the icons are duplicated. Is that on purpose? Should one of the duplicated images be removed?

visControls is the same icon as controlsHorizontal
visHeatmap is the same icon as heatmap
@snide
Copy link
Contributor

snide commented Aug 9, 2019

We should probably yank them. Marked as a good first issue.

@mdefazio
Copy link
Contributor

mdefazio commented Sep 3, 2019

How do we determine which to keep? Does it make sense to keep the generic ones and remove the app specific (visControls/Heatmap).

@nreese
Copy link
Contributor Author

nreese commented Sep 3, 2019

How do we determine which to keep? Does it make sense to keep the generic ones and remove the app specific (visControls/Heatmap).

+1 for keeping generic icons and removing app specific versions

@ryankeairns
Copy link
Contributor

Another +1 for keeping generic. Note that we'll need to do a search-and-replace in Kibana to swap out those that have been removed.

@anishagg17
Copy link
Contributor

@nreese
I am working on this issue

@anishagg17 anishagg17 mentioned this issue Feb 24, 2020
Merged
7 tasks
cchaos added a commit that referenced this issue Feb 24, 2020
@anishagg17 @cchaos
Fixes #2217 : removed duplicate icons (#2908)
981914e 
* removed duplicate icons

* Fixing changelog and updating tests (#1)

Co-authored-by: Caroline Horn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2217 : removed duplicate icons anishagg17/eui
5 participants
@snide @nreese @ryankeairns @mdefazio @anishagg17