[5.0.0] Updated to React v16, added portal for PopOver, updated to emojione v3, refactored and restyled Message, replaced dangerouslySetInnerHTML with html-react-parser and adjusted some styling to 8dp grid #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erride, added fallback styles for ListItem avatar and rightButton, fixed MenuItem icon alignment, added more component tests, refactored docs icons page.
* 📝 Added team to readme. * 📦 Added contributers to package.json.
* Created component test for card header * Created component test Empty-state * added an extra test for empty-state component test
* 🔥 Removed active icon. * ✨ Added rightButton feature to menu-item. * 📝 Added menu-item with rightButton to docs. * 📝 DocGen. * 💚 Fixed failing tests. * 🚨 Fixed linting error. * 💄 Changed active style * 📝 Changed to IconMenu example
* Created component test for card header * Created component test for input * Added an error styles test to component test
* Created component test for card header * Created component test for List * added children prop to test * Added test for children prop
…x, added more component tests.
* Created component test for card header * Created component test for menu-item * Created component test for menu-item * 🐛 Added buttonStyle * ✅ Fixed test
* Created component test for card header * Created component test for Modal
* Created component test for card header * Created component test overlay
* Fixed props in admin-badge test * Fixed props in alert test * Changed test order for alert test * Fixed props for app-header test * Fixed props for avatar test * Fixed describe title for avatar test * Fixed props for badge test * Fixed props for button test * Fixed props for card test * Fixed test description for card test * Fixed props for card-content test * Fixed describe title for card-content test * Fixed test description for card-content test * Fixed props for card-header test * Fixed test for title test * Fixed props for channel-header test * Changed test order for channel-header test * Fixed props for checkbox test * Fixed props for dialog test * Fixed small spelling error for dialog test * Fixed props for divider test * Fixed props for empty-state * Fixed describe title for empty-state test * Removed unnecessary button import * Fixed props for input test * Fixed small errors * Fixed props for list test * Fixed props for profile test
* Created component test for card header * Created component test for Lightbox * Added tests * Fixed small spelling error * Update index.test.js
* Created component test Pop-over * modified discripition
* Created component test for radio-button * editted description
* Added test for table * Added test for table-body * Added test for table-column * Added test for table-header * Added test for table-header-column * Added test for table-row
* Added test for switch * Edited test description
* ✨ Added typing message * 📝 Docgen * 📝 Added typing example
* 🌐 Added locale to Message * 💄 Fixed link styles
…essage, fixed Message link styles, added more component tests.
* Added onclick test for alert * Added onclick test for button * Undid onclick test for alert * Added onclick test for dialog * Added onclick test for lightbox * Undid the undoing of onclick test for alert * Added another onclick test for dialog * Added another onclick test for lightbox * Added onclick test for menu-item * Fixed the broken stuff
* Added image preloader * Image is global * Added basic docs page, needs more styling * Remove logging * In componentWillReceiveProps do not check for existing, only compare with previous * Consistent naming, errorComponent and preloadComponent * Added code example * Wrap example text in p * Fixed example. * Improved docs. * Remamed component. * Renamed files. * Renamed docs. * More renaming. * Renamed prop. * Removed Status constant. * Added component description. * Fixed prop description. * Docgen. * Fixed route. * Fixed docs page styling. * Sorted imports.
* Fixed badge uncovered lines. * Fixed broken test.
* Added after succes to travis for CodeCoverage. * Reverted codecov package change. * Added coveralls package and npm script for travis. Should fix #977. * Small adjustments. * Should fix it. * Added coverage badge to readme. * Small naming changes. * Adjusted mocha opts. * Use codecov instead * Added codecov.yml. * Changed badge to codecov badge.
* Added ImageLoader to image and giphy messages. * Added imagePlaceholder, imageError and onImageLoad. * Added onImageError.
* Updated eslint config. * Fixed linter error. * Fixed linter error. * Disabled rule. * Fixed linting errors. * Fixed linting errors. * Fixed linting errors. * Fixed linting errors. * Fixed linting errors. * Fixed linting errors. * Fixed code styling. * Fixed code styling. * Fixed code styling. * Disabled rule. * Fixed linting errors. * Fixed linting errors. * Fixed linting errors. * Fixed linting errors. * Fixed linting errors. * Fixed linting errors. * Fixed linting errors. * Fixed linting errors. * Fixed linting error. * added () to fix unexpected newlines before/after )/( * removed unused default props * rewritten component to be a pure functionm * added rule to disable nesting htmlFor * fixed slider * fixed indenting * removed comment disable-line * removed max-len rule * removed comment, moved to oneline * removed multiple (( )) on calledWith * fixed tests * added comment * altered comment
* Issue #848 (#888) * Removed redundant typing message. * Removed redundant import. * Moved iconMenu into message body. * WIP added style to iconMenu for clean messages. * Moved sticker header on top of sticker body. * Added styles for sticker IconMenu. * Moved time on top of images and giphies. * Added styles for compact with new IconMenu placement. * Fixed collapsed styles. Fixes #848. * Fixed tests. * Added test for sticker messages. * Added styles for iconMenu in MessageHeader. * Bumped maxWidth of container to 80%. * Added readability maxWidth to TextMessage. * Issue #806 (#893) * Added menuIcon to Message. * Removed unused styles. * Replaced custom menus with iconMenu prop. * Added styles for iconMenu. * Applied API changes. * Fixed collapsedText. * Adjusted styles to look more like design. * Fixed sticker message styling. * Fixed tests. * Fixed sticker stretching. * Added font scaling for messageTime. * Removed redundant width styling from messageTime. * Fixed tests. * Issue #930 (#934) * Bumped react react-dom and html-react-parser version. * Bumped react and react-dom version. * Fixed all the tests. Fixes #930. * Created default style file to make message styles more dry. Fixes #494. (#949) * Replace dangerouslySetInnerHTML with html-react-parser. Fixes #761. (#951) * Replace dangerouslySetInnerHTML with html-react-parser. Fixes #761. * Removed createMarkup function. * Implemented 8dp grid to AppHeader. (#956) * Issue #751 alert (#955) * Implemented 8dp grid to Alert. * Cleaned-up Alert getStyle. * Reversed test. * Refactored message-list, made ref work again (#961) * Refactored message-list * renamed * Eslint fixes * Replaced emojione.imagePathPNG for emojione.emojiSize. Fixes #725. (#964) * Issue #783 (#948) * Bumped react react-dom and html-react-parser version. * Bumped react and react-dom version. * Fixed all the tests. Fixes #930. * Added react-portal to portal pop-over element to bottom of root. * Added own portal component. * Deconstructed props. * Added doc page about portal component. Fixes #783. * Added example for portal component. * Added description for docs page. * Added description for docs page. * Added alert about react v16. * Made passthrough for portal node prop instead. * Fixed Selects positioning. * Fixed pop-over-position test. * DocGen. * Adjusted in favor of comments. * Fixed broken check. * Changed example. * Changed text. * Cleanup. * Docgen. * Issue #872 (#950) * Added variable middle alignment for when it gets cut of. * Fixed horizontal middle so it actually alligns in the middle. * Added variable middle alignment for when it gets cut off horizontal. * Added 16 margin around the variable placements. * Fixed broken tests. * Added test for offset positioning. Fixes #872. * Removed logging. * Adjusted naming. * Implemented 8dp grid to Banner. (#968) * Implemented 8dp grid to Button. (#969) * Implemented 8dp grid to Card. (#970) * Issue #751 admin badge (#990) * Implemented 8dp grid to AdminBadge. * Fixed linting error. * Fixed broken test. * Implemented 8dp grid to AdminBadge. (#992)
…3, refactored and restyled Message, replaced dangerouslySetInnerHTML with html-react-parser and adjusted some styling to 8dp grid.
|
Would be nice to have a MIGRATION.md file. What do I have to do to use this release, while running v4.x. |
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
==========================================
+ Coverage 96.54% 98.77% +2.23%
==========================================
Files 119 123 +4
Lines 810 900 +90
==========================================
+ Hits 782 889 +107
+ Misses 28 11 -17
|
sjaakluthart
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.