Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PopOver] Handle horizontal middle align #872

Closed
IanCStewart opened this issue Sep 27, 2017 · 0 comments
Closed

[PopOver] Handle horizontal middle align #872

IanCStewart opened this issue Sep 27, 2017 · 0 comments
Labels
bug enhancement
Milestone
5.0.0

Comments

@IanCStewart
Copy link
Contributor

If a PopOver won't fit on both right and left it should figure out an offset instead. Now it just breaks.
IanCStewart added a commit that referenced this issue Nov 9, 2017
@IanCStewart
Added test for offset positioning. Fixes #872.
0f04d3a
@IanCStewart IanCStewart added this to the 5.0.0 milestone Nov 9, 2017
sjaakluthart pushed a commit that referenced this issue Nov 13, 2017
@IanCStewart
Issue #872 (#950)
ddaad8f 
* Added variable middle alignment for when it gets cut of.

* Fixed horizontal middle so it actually alligns in the middle.

* Added variable middle alignment for when it gets cut off horizontal.

* Added 16 margin around the variable placements.

* Fixed broken tests.

* Added test for offset positioning. Fixes #872.

* Removed logging.

* Adjusted naming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
1 participant
@IanCStewart