feat: change output directory from "server" to "analog" #300
Conversation
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@brandonroberts netlify deploy is most likely failing due to the fact that the output directory was renamed. I didn't see a way to make changes to the netlify config in the repo. I assume it is some change in Github? Thank you! |
|
Thank @goetzrobin! I updated the Netlify config to the new directory and restarted the deploy previews |
|
@brandonroberts Good catch! Thank you! I will update that section! still seeing some errors with the netlify deploy 🤕 12:17:02 PM: Section completed: deploying
12:17:02 PM:
12:17:02 PM: Configuration error
12:17:02 PM: ────────────────────────────────────────────────────────────────
12:17:02 PM:
12:17:02 PM: Error message
12:17:02 PM: Deploy did not succeed: Deploy directory 'dist/apps/blog-app/server/public' does not exist |
|
Blog app should be resolved also https://deploy-preview-300--analog-blog.netlify.app/blog |
goetzrobin
force-pushed
the
rename-dist-server-to-analog
branch
from
2830047
to
c8cbf24
Compare
made the changes so the vite-nitro-plugin.ts outputs to an "analog" folder instead of "server" folder. added an integration test for the blog-app that uses the build output from said "analog" folder. Tried to do the same for the analog-app but ran into this issue with nx and cypress: nrwl/nx#10814. Waiting for guidance on that before making any other e2e changes. I think ideally we check this output as part of the e2e test for create analog as described in issue 201. Closes analogjs#295
goetzrobin
force-pushed
the
rename-dist-server-to-analog
branch
from
c8cbf24
to
c596311
Compare
I got a 404 for that url, but that url only. Everything else works and https://deploy-preview-300--analog-blog.netlify.app also redirects correctly. I added /blog to the pre-rendered routes. All looks good to me now 🚀 |
Closes analogjs#295 BREAKING CHANGES: The output for the built client/server application has changed BEFORE: The output for the built server application is `dist/server/public` for client and `dist/server/server` for server AFTER: The output for the built server application is `dist/analog/public` for client and `dist/analog/server` for server
made the changes so the vite-nitro-plugin.ts outputs to an "analog" folder instead of "server" folder. added an integration test for the blog-app that uses the build output from said "analog" folder. Tried to do the same for the analog-app but ran
into this issue with nx and cypress: nrwl/nx#10814.
Waiting for guidance on that before making any other e2e changes.
I think ideally we check this output as part of the e2e test
for create analog as described in issue #201.
Closes #295
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Final output that makes up the Analog server is in the server directory
Issue Number: #295
What is the new behavior?
Does this PR introduce a breaking change?
Deploy scripts of applications using default paths need to be updated to point to the analog directory instead of server directory
Other information