Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: change output directory for server build to "analog" instead of "server" #295

Closed
2 tasks
brandonroberts opened this issue Mar 17, 2023 · 1 comment · Fixed by #300
Closed
2 tasks

Feature: change output directory for server build to "analog" instead of "server" #295

brandonroberts opened this issue Mar 17, 2023 · 1 comment · Fixed by #300
Assignees
@goetzrobin
Labels
accepting PRs enhancement New feature or request

Comments

@brandonroberts
Copy link
Member

Which scope/s are relevant/related to the feature request?

platform

Information

When a server build is produced, a few directories are created

  • dist
    • .nitro
    • client (Client build)
    • server <-- changed to analog
      • public
      • server
    • ssr (SSR build)

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@brandonroberts brandonroberts added the enhancement New feature or request label Mar 17, 2023
@goetzrobin
Copy link
Member

@brandonroberts I can work on this one

goetzrobin added a commit to goetzrobin/analog that referenced this issue Mar 20, 2023
@goetzrobin
feat: change output directory from "server" to "analog"
2830047 
made the changes so the vite-nitro-plugin.ts outputs to
an "analog" folder instead of "server" folder. added an integration
test for the blog-app that uses the build output from said
"analog" folder. Tried to do the same for the analog-app but ran
 into this issue with nx and cypress:
 nrwl/nx#10814.
 Waiting for guidance on that before making any other e2e changes.
 I think ideally we check this output as part of the e2e test
 for create analog as described in issue 201.

Closes analogjs#295
@goetzrobin goetzrobin mentioned this issue Mar 20, 2023
Merged
19 tasks
goetzrobin added a commit to goetzrobin/analog that referenced this issue Mar 20, 2023
@goetzrobin
feat: change output directory from "server" to "analog"
c8cbf24 
made the changes so the vite-nitro-plugin.ts outputs to
an "analog" folder instead of "server" folder. added an integration
test for the blog-app that uses the build output from said
"analog" folder. Tried to do the same for the analog-app but ran
 into this issue with nx and cypress:
 nrwl/nx#10814.
 Waiting for guidance on that before making any other e2e changes.
 I think ideally we check this output as part of the e2e test
 for create analog as described in issue 201.

Closes analogjs#295
goetzrobin added a commit to goetzrobin/analog that referenced this issue Mar 20, 2023
@goetzrobin
feat: change output directory from "server" to "analog"
c596311 
made the changes so the vite-nitro-plugin.ts outputs to
an "analog" folder instead of "server" folder. added an integration
test for the blog-app that uses the build output from said
"analog" folder. Tried to do the same for the analog-app but ran
 into this issue with nx and cypress:
 nrwl/nx#10814.
 Waiting for guidance on that before making any other e2e changes.
 I think ideally we check this output as part of the e2e test
 for create analog as described in issue 201.

Closes analogjs#295
brandonroberts pushed a commit that referenced this issue Mar 20, 2023
@goetzrobin
feat: change output directory from "server" to "analog" (#300)
2267afc 
Closes #295 

BREAKING CHANGES:

The output for the built client/server application has changed

BEFORE:

The output for the built server application is `dist/server/public` for client and `dist/server/server` for server

AFTER:

The output for the built server application is `dist/analog/public` for client and `dist/analog/server` for server
Villanuevand pushed a commit to Villanuevand/analog that referenced this issue Sep 12, 2023
@goetzrobin @Villanuevand
feat: change output directory from "server" to "analog" (analogjs#300)
70d8092 
Closes analogjs#295 

BREAKING CHANGES:

The output for the built client/server application has changed

BEFORE:

The output for the built server application is `dist/server/public` for client and `dist/server/server` for server

AFTER:

The output for the built server application is `dist/analog/public` for client and `dist/analog/server` for server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goetzrobin goetzrobin

Labels
accepting PRs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: change output directory from "server" to "analog" goetzrobin/analog
2 participants
@brandonroberts @goetzrobin