Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint Airbnb #154

Closed
davixyz opened this issue Oct 4, 2018 · 4 comments
Closed

ESLint Airbnb #154

davixyz opened this issue Oct 4, 2018 · 4 comments
Milestone

Comments

@davixyz
Copy link
Contributor

davixyz commented Oct 4, 2018

This might be a little controversial but:
As we move into ES6 world it would be good to also update the linter to a harder one
Here's my suggestion:
https://github.com/airbnb/javascript
Using:
https://www.npmjs.com/package/eslint-config-airbnb-base

If we don't go the ES6 path there's also a legacy ES5 airbnb linter

@chazzmoney chazzmoney added this to the 3.0 milestone Oct 5, 2018
@vvscode
Copy link

vvscode commented Oct 16, 2018

And this one I'm also ready to take

@chazzmoney
Copy link
Collaborator

Might consider doing this in conjunction with #153

Actually, maybe we should wait on both of these until we merge #169

dbanksdesign pushed a commit that referenced this issue Oct 26, 2018
Fixes: #153, #154

* apply air-bnb-base config
* use let/const
* use arrow functions
* use object shorten forms
* use templates
@vvscode
Copy link

vvscode commented Nov 1, 2018

@davixyz what about closing?

@dbanksdesign
Copy link
Member

Sorry about that! Done! Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants