Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite to ES6 #153

Closed
davixyz opened this issue Oct 4, 2018 · 13 comments
Closed

Rewrite to ES6 #153

davixyz opened this issue Oct 4, 2018 · 13 comments
Milestone

Comments

@davixyz
Copy link
Contributor

davixyz commented Oct 4, 2018

Had a talk with @dbanksdesign and basically we could start migrating the library little by little to use ES6 features. Of course this needs some infrastructure work (that I would love to do) and also to take some decisions about how do we do this. Opening this issue to start the conversation for this.

Some Thoughts

  • Some of the features are already available in node 6 and node 8, probably the most important ones we would want like template literals, spreads, destructuring etc
  • Replacing and using arrow functions everywhere might be tricky because of how style dictionary API has been designed with this in mind
  • A build system will be required to ship the code for older versions

Some build systems

@chazzmoney chazzmoney added this to the 3.0 milestone Oct 5, 2018
@vvscode
Copy link

vvscode commented Oct 16, 2018

There is https://github.com/5to6/5to6

I'm ready to do it

@chazzmoney
Copy link
Collaborator

Thats cool! I didn't know that was even a thing that existed.

If you are ready, go for it. Otherwise I can take a look next week.

@chazzmoney
Copy link
Collaborator

Probably best done in conjunction with #154.

I think we should wait on this until we merge #169 before doing this.

@vvscode
Copy link

vvscode commented Oct 19, 2018

So I'm waiting for merge #169 to make this one and #154

To which branch?

@dbanksdesign
Copy link
Member

develop-3.0

@vvscode
Copy link

vvscode commented Oct 19, 2018

@dbanksdesign @chazzmoney are you going to merge develop to develop-3.0 ?

@chazzmoney
Copy link
Collaborator

Yes, sorry for the delay. Going to try to get #158 and #152 merged into develop in the next couple days and then merge develop into develop-3.0

@dbanksdesign
Copy link
Member

develop-3.0 is now up to date with develop

dbanksdesign pushed a commit that referenced this issue Oct 26, 2018
Fixes: #153, #154

* apply air-bnb-base config
* use let/const
* use arrow functions
* use object shorten forms
* use templates
@chazzmoney
Copy link
Collaborator

Promise to get #152 merged soon - almost there. Thanks for your patience @vvscode.

@dbanksdesign
Copy link
Member

#500 is the beginnings of this

@dbanksdesign
Copy link
Member

@chazzmoney you think we can close this?

@davixyz
Copy link
Contributor Author

davixyz commented Nov 10, 2021

If this is finished, we should close it! Hello everyone!

@dbanksdesign
Copy link
Member

This is done (for the most part)! Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants