🌐 [amp story shopping] i18n "reviews" string capitalization description

[processprocess]

Provides clarity in the string description on why the "reviews" string is not capitalized. This was asked during code review and in a comment.

[amp-owners-bot]

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/_locales/en.json

[ilyaspiridonov]

Hey @processprocess thanks for the clarification, but this may actually be an example of a classic problem in localisation :)

Here's why:

1. In some languages translators may want/need to change the word order (e.g. Arabic)
2. In some languages reviews will change its form depending on the number that precedes it. Russian is a typical example:

1 отзыв
2 отзыва
86 отзывов

BTW, you'll actually also get 1 reviews in English :)

There are some ways around this that are used in different frameworks (e.g. Pluralisation in Vue i18n), however, the easiest one would be rephrasing the translation - which, again, will often lead to changing the word order:

Отзывов: 86
OR
Отзывы (86)
OR
Отзывы - 86

With that in mind, is there any way we can avoid concatenation - e.g. by using variables?

"string": "$reviews_count$ reviews"

Ideally, concatenation should always be avoided in localization (even when not dealing with variables), as reversed word order is quite common in many languages.

[ilyaspiridonov]

@processprocess should I open an issue for this?

[processprocess]

@processprocess should I open an issue for this?

@ilyaspiridonov that would be great :)
Please assign me to the issue once it's written.

We might need to remove the translated string and use a design pattern like this:

[ilyaspiridonov]

@processprocess should I open an issue for this?

@ilyaspiridonov that would be great :) Please assign me to the issue once it's written.

Done! #38060
(Not sure I can assign you though... )

We might need to remove the translated string and use a design pattern like this:
This looks good indeed!

What should we do with the 'reviews' string in the meantime from the translation perspective - leave in English for now?
CC @newmuis

[gmajoulet]

Pluralization or string interpolation are out of scope for our localization system.

I think we should either:

1a. Update the description, show how the "review" string will be used, and ask translators to pay attention to whether it should be uppercase or not
1b. Always use plural

or

2a. Remove the "reviews" string and only show the content, as @processprocess suggested

[processprocess]

Closing this PR since it doesn't fix the root of the problem.
As Gabriel mentioned in 2a, just showing the content would be good since it removes this problem.
I updated the description of #38060 to reflect this.