Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [amp story captions] get and set captions state from viewer #38009

Merged
merged 3 commits into from
Apr 18, 2022

Conversation

processprocess
Copy link
Contributor

@processprocess processprocess commented Apr 4, 2022

Functionality and tests to get and set captions state from viewer.

Closes #37898

@processprocess processprocess changed the title ✨ [amp story player] get and set captions state from viewer ✨ [amp story captions] get and set captions state from viewer Apr 4, 2022
@processprocess processprocess marked this pull request as ready for review April 18, 2022 14:57
@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-viewer-messaging-handler.js
extensions/amp-story/1.0/test/test-amp-story-viewer-messaging-handler.js

@gmajoulet
Copy link
Contributor

Bundle-size shows +1kB, can you rebase your PR and make sure everything is ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Amp story captions] Allow Players to get/set the captions state
4 participants