Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Amp story captions] Allow Players to get/set the captions state #37898

Closed
processprocess opened this issue Mar 18, 2022 · 0 comments · Fixed by #38009
Closed

[Amp story captions] Allow Players to get/set the captions state #37898

processprocess opened this issue Mar 18, 2022 · 0 comments · Fixed by #38009

Comments

@processprocess
Copy link
Contributor

processprocess commented Mar 18, 2022

Description

This will likely happen here:

/** @enum {!GetStateConfigurationDef} */
const GET_STATE_CONFIGURATIONS = {
'CURRENT_PAGE_ID': {
dataSource: DataSources.STORE_SERVICE,
property: StateProperty.CURRENT_PAGE_ID,
},
'EDUCATION_STATE': {
dataSource: DataSources.STORE_SERVICE,
property: StateProperty.EDUCATION_STATE,
},
'MUTED_STATE': {
dataSource: DataSources.STORE_SERVICE,
property: StateProperty.MUTED_STATE,
},
'PAGE_ATTACHMENT_STATE': {
dataSource: DataSources.STORE_SERVICE,
property: StateProperty.PAGE_ATTACHMENT_STATE,
},
'UI_STATE': {
dataSource: DataSources.STORE_SERVICE,
property: StateProperty.UI_STATE,
},
'STORY_PROGRESS': {
dataSource: DataSources.VARIABLE_SERVICE,
property: AnalyticsVariable.STORY_PROGRESS,
},
};
/** @typedef {{action: !Action, isValueValid: function(*):boolean}} */
let SetStateConfigurationDef;
/** @enum {!SetStateConfigurationDef} */
const SET_STATE_CONFIGURATIONS = {
'MUTED_STATE': {
action: Action.TOGGLE_MUTED,
isValueValid: (value) => typeof value === 'boolean',
},
};
.

Blocked by #37884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant