Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗🚀 Mangle values of specific enum objects #37480

Merged
merged 2 commits into from
Feb 2, 2022
Merged

🏗🚀 Mangle values of specific enum objects #37480

merged 2 commits into from
Feb 2, 2022

Conversation

alanorozco
Copy link
Member

@alanorozco alanorozco commented Jan 26, 2022 •
edited
Loading

Restores #36935

@alanorozco alanorozco mentioned this pull request Jan 26, 2022
Merged
@alanorozco alanorozco marked this pull request as ready for review January 26, 2022 02:15
@amp-owners-bot
Copy link

Hey @erwinmombay! These files were changed:

build-system/babel-plugins/babel-plugin-mangle-object-values/index.js
build-system/babel-plugins/babel-plugin-mangle-object-values/test/fixtures/transform/mangle/input.js
build-system/babel-plugins/babel-plugin-mangle-object-values/test/fixtures/transform/mangle/output.js
build-system/babel-plugins/babel-plugin-mangle-object-values/test/fixtures/transform/options.json
build-system/babel-plugins/babel-plugin-mangle-object-values/test/index.js
build-system/eslint-rules/no-import-rename.js

Hey @jridgewell! These files were changed:

build-system/babel-plugins/babel-plugin-mangle-object-values/index.js
build-system/babel-plugins/babel-plugin-mangle-object-values/test/fixtures/transform/mangle/input.js
build-system/babel-plugins/babel-plugin-mangle-object-values/test/fixtures/transform/mangle/output.js
build-system/babel-plugins/babel-plugin-mangle-object-values/test/fixtures/transform/options.json
build-system/babel-plugins/babel-plugin-mangle-object-values/test/index.js
build-system/eslint-rules/no-import-rename.js
src/core/types/enum.js

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-store-service.js

alanorozco
alanorozco commented Jan 26, 2022
View reviewed changes
examples/visual-tests/amp-story/info-dialog.html
// Automatically open the info dialog.
const openInfoDialogEvent = new CustomEvent('ampstory:dispatchaction', {
detail: {
action: 'toggleInfoDialog',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toggleInfoDialog is not valid on runtime, using an interactive test instead.

@alanorozco alanorozco merged commit fb3fb36 into ampproject:main Feb 2, 2022
@alanorozco alanorozco deleted the mangle-enum branch February 2, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszylkowski mszylkowski mszylkowski approved these changes

@gmajoulet gmajoulet gmajoulet approved these changes

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alanorozco @jridgewell @gmajoulet @mszylkowski @ampprojectbot