🏗🚀 Mangle values of specific enum objects #36935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @erwinmombay! These files were changed: Hey @jridgewell! These files were changed: Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
approved these changes
Nov 16, 2021
jridgewell
requested changes
Nov 16, 2021
build-system/babel-plugins/babel-plugin-mangle-object-values/index.js
Outdated
Show resolved
Hide resolved
build-system/babel-plugins/babel-plugin-mangle-object-values/index.js
Outdated
Show resolved
Hide resolved
| if (!charset) { | ||
| // Letters first since they allow unbracketed syntax when used as keys: | ||
| // (foo.a0 vs. foo['0a']) | ||
| charset = indexCharset( |
There was a problem hiding this comment.
Optional: If there are only 10 (or fewer) enum values, we could optimize to a number instead. That'd save a few bytes.
There was a problem hiding this comment.
If we use numbers let's please exclude 0 that's falsy
There was a problem hiding this comment.
From my local output, using numbers from 0..99 seems to reduce the amp-story bundle by a further 75 B compressed. Cool!
Note that I'm using letters only for values ≥ 99 since we could be using the enum values as keys (like StateProperty) and we'd like to prevent the collision of foo[0] vs. foo['0']
jridgewell
approved these changes
Nov 17, 2021
...tem/babel-plugins/babel-plugin-mangle-object-values/test/fixtures/transform/mangle/output.js
Outdated
Show resolved
Hide resolved
alanorozco
force-pushed
the
mangle-service-keys
branch
from
8352b92
to
bb78393
Compare
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Nov 17, 2021
This reverts commit 5f27973.
alanorozco
added a commit
that referenced
this pull request
Nov 17, 2021
alanorozco
added a commit
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces compressed size of
amp-storybundles by ~0.6K