Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ ✅ 🐛 Add new data attributes to amp-jwplayer #35163

Merged
merged 15 commits into from
Sep 9, 2021
Merged

✨ ✅ 🐛 Add new data attributes to amp-jwplayer #35163

merged 15 commits into from
Sep 9, 2021

Commits on Jul 27, 2021

  1. Add JW Player to documentation that applies

    @mamaddox
    Zack Haigh authored and mamaddox committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    caa3227 View commit details
    Browse the repository at this point in the history

  2. Revert "Add JW Player to documentation that applies" 

    This reverts commit 5aeba5a.
    @mamaddox
    mamaddox committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    49b2a4f View commit details
    Browse the repository at this point in the history

  3. Extend AMP Params (#62) 

    * Add setup method

* create separate postMessage method and add setup test

* adding support for data-params and querystring

* updating tests for data-params

* re-adding unit test i accidentally removed

* Pass custom config added through amp to player

* Use correct import format

* updated attribute names

* adding code suggestions

* Add test coverage and fix formatting

* Move test config to above assertation

* Update media id and player id for vast ad config

* Add cust-params data attribute for ads

* testing

* Integrate with amp-consent and add custom macros

* Lint fixes

Co-authored-by: Daniel Lee <[email protected]>
    @mamaddox @Dawolee
    mamaddox and Dawolee committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    6614894 View commit details
    Browse the repository at this point in the history

  4. Remove bad import

    @mamaddox
    mamaddox committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    df4d9eb View commit details
    Browse the repository at this point in the history

  5. Clean up consentgdpr

    @mamaddox
    mamaddox committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    076ded0 View commit details
    Browse the repository at this point in the history

  6. Add comment about appending querystring

    @mamaddox
    mamaddox committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    89da1ff View commit details
    Browse the repository at this point in the history

  7. Clean up from rebase

    @mamaddox
    mamaddox committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    77dc0b4 View commit details
    Browse the repository at this point in the history

  8. Remove trailing whitespaces

    @mamaddox
    mamaddox committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    d23a21d View commit details
    Browse the repository at this point in the history

  9. Remove controls attribute

    @mamaddox
    mamaddox committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    566f898 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. 📖 [JW8-11873] Update JW Player AMP Docs (#61) 

        Update our amp-jwplayer docs with the new attributes
    Add amp-jwplayer in the docs where it applies
    @mamaddox
    mamaddox authored Aug 2, 2021
    Configuration menu
    Copy the full SHA
    bb027d2 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. Merge branch 'main' into extend-amp-params

    zetagame committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    09f7fb8 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. cleanup rebase

    zetagame committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    8a00988 View commit details
    Browse the repository at this point in the history

  2. lint fixes

    zetagame committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    7f7f398 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Merge branch 'main' of github.com:ampproject/amphtml into extend-amp-… 

    …params
    zetagame committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    d0c304f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:ampproject/amphtml into extend-amp-… 

    …params
    zetagame committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    332f6dc View commit details
    Browse the repository at this point in the history