Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ amp-story-desktop-one-panel Position system layer UI on top of story panel #34907

Merged
merged 7 commits into from
Jun 17, 2021
Merged

✨ amp-story-desktop-one-panel Position system layer UI on top of story panel #34907

merged 7 commits into from
Jun 17, 2021

Conversation

processprocess
Copy link
Contributor

Context / Fixes #34823

  • Positions system layer UI on top of story panel.
  • Creates variables for any shared values.

demo

@amp-owners-bot
Copy link

amp-owners-bot bot commented Jun 17, 2021 •
edited
Loading

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-desktop-one-panel.css
extensions/amp-story/1.0/amp-story-system-layer.css
extensions/amp-story/1.0/amp-story-system-layer.js

@processprocess processprocess merged commit c039c04 into ampproject:main Jun 17, 2021
@processprocess processprocess deleted the system-ui branch June 17, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amp-story-desktop-one-panel System layer positioning
2 participants
@processprocess @gmajoulet