Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-story-desktop-one-panel System layer positioning #34823

Closed
processprocess opened this issue Jun 10, 2021 · 0 comments · Fixed by #34907
Closed

amp-story-desktop-one-panel System layer positioning #34823

processprocess opened this issue Jun 10, 2021 · 0 comments · Fixed by #34907

Comments

@processprocess
Copy link
Contributor

Description

Position the system layer so they are overlaid on story.
CSS code will be repeated from amp-story-page positioning.

Alternatives Considered

We considered a wrapper element for the pages and system layer but that would require reparenting all pages and runtime. This would be a performance hit and would require a re-measure of essentially the entire story.

It also effects all other UI types by adding an additional wrapper, increasing surface for bugs.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant