✨ [ads2.bid] amp-ad ads2bid implementation #34806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lannka Hello! How long can we wait for approval? |
lannka
approved these changes
Jul 21, 2021
…pproject#36947) Partial for ampproject#36899 Refactor `{attrPrefix}` and `{type: 'date'}` so that they resolve to a `{parseAttrs}` config instead. This allows extension bundles to include these parsing mechanisms independently, rather than sharing it as part of `PreactBaseElement`. All Bento extensions are 0.03 kb to 0.25 kb smaller as a result. The `bento.js` binary should see similar savings once it includes shared dependencies.
Reduces compressed size of `amp-story` bundles by ~0.6K
Removing because it has no effect.
* compiler: create buildDom for amp-carousel 0.1 * good shape for scrollableCarousel * fully implemented * fix 1 real bug and the tests * cleantown * add buildDom tests * make hasPrev/hasNext private * small cleanup * satisfy weird closure rule around default args and destructuring * address first round of rcebulko comments * typos, small nits
* remove createPortal
* replace toChildArray with the fn from preact
* copy/paste forwardRef implementation
…6978) * Fix batchedReads being shared by different callers In the old code, `batchedRead` performed a file read, and hashed the contents with an input `optionsHash`. But `batchedRead` is designed to allow multiple callers to share the same file, and they may provide different `optionsHash`es. When this happened, only the first caller's read+`optionsHash` would be used, and the 2nd+ caller would receive the first caller's hashes! This simple fix is to move this out of `batchedRead` and let that just _read_ and hash the file contents. If you want to rehash with options, do that afterwards. * Fix incorrect reference to file hash * Fix files with duplicated contents compiling incorrectly
* Compressed share icons * Removed google+ assets * Simplify twitter share icon * Not fail with gplus * Not block space for gplus
…mpproject#36757) * Added examples for inline and remote config loading of json files. * finished tests for shopping config * removed unnescessary function call * removed chai import * removed unnesc assignment * fixed prettier lint warnings * added dependencies for store service * cleanup up code and tests to optmize code flow * cleaned up config files and test files * added more refactoring of shopping story * Updated test code with new tag id * fixed formatting of remote file * added remote config fiel formatting fix * added visual diff test * updated visual diff test * updated unit tests to use public facing apis, removed dead code * updated unit tests to use public facing apis, removed dead code * updated unit tests to use public facing apis, removed dead code * added page id * added load config impl (both solutions: one exposed export public method, and another private moethd that gets called, fallback to the exported loadconfigimpl if suggested by the review team) * removed export ()may need to put back if want to use public facing apit * modified laodconfig to handle 404 errors * removed unused var * added dependency for request service * added a few recotoring shareconfig menthod * refactored code to use new request service. * removed unused allow list entry * added buidlcallback resolve * added implicit return * added in code refactos * updated shoo[[ing state to shopping data * removed promise.resolve * recatored shopping and shared config unit test code * added in config refactor logic * streamlined commens and code * fixed comment for circleci * optmized code and unit tests * added shared config code * refactored dead code * added typedefs * added in refactor of social share widget * added shopping story test features * removed unnneded export * udpated product images array * removed trailign whitespace * removed unused vars * removed unused config for now * added back in dev asserts * code compactification * stripped dev assert * fixed social share config
* Use stable identifier mangling for properties * Reverse id mangling Maybe we'll hit better compression with longer `const a=` or `let a=` back references.
* Compressed share icons * Removed google+ assets * Simplify twitter share icon * Not fail with gplus * Not block space for gplus * Added utf8
* Cleanup forwardRef implementation * Fix bug with forwarding a null ref Functional components are only ever called during render/diff, not dismount, so the ref should never be null. * Don't depend on `self` (browser global)
PiperOrigin-RevId: 409990959 Co-authored-by: Googler <[email protected]>
* compiler: use .ts files * touchups * surprise
…37399) Co-authored-by: Greg Grothaus <[email protected]>
* Update OWNERS for tsconfig and compiler * rcebulko feedback * lint
* add trigger promote * comments * config
* internal changes PiperOrigin-RevId: 417462074 * Open source wasm AMP validator PiperOrigin-RevId: 417488889 * Use plain string rather than Symbol in validator js PiperOrigin-RevId: 419907682 * Fix a bug that compares string against number PiperOrigin-RevId: 419931677 * Make htmlparser dedupe node attributes deterministically. Non-deterministic deduping results in non-deterministic amp validator behavior. E.g. if there are two "width" attributes with different values, the layout validation may or may not produce a specific width-related error (even though validator will always detect attribute duplication itself, and fail). PiperOrigin-RevId: 421140196 Co-authored-by: Boxiao Cao <[email protected]> Co-authored-by: Googler <[email protected]>
|
@calebcordry, could you give me an answer, please? What is the problem with CircleCI? |
|
Maybe we should just make a new merge request? This has been going on for a very long time... |
|
Sorry missed this. Something like: git checkout main
git pull upstream main
git checkout <your_branch>
git rebase main
git push origin <your_branch>should sync everything to HEAD of our main branch. This fixes most CI errors. |
* added some shopping tag text specs * added shopping tag text specs * fixed shopping tag * fixed shopping tag * added visual diff test * fixed nit, one liner comment * added dynamic border radius for styling with two tag texts * added better name * added correct calls for clientrect for using measuremutate eleemnt * updated spec exampel to have tags with rtl support, used arabic as the demonstration language. * fixed a few issues with shopping tag specs * resolved mrege conflicts iwth main * removed duplicate page id * fixed blank page on no products * added suggestion about ?. null operator * added text specs * added parseInt to font size to fix border radius * fixed all issues except for multi-line ellipsis * added shopping tag text specs ellipsis fix (it had to do with flex display) * rmeoved gitignore file * added mutate element * added more relvant example * updated visual diff tests * added classlist optimization for mutatelement * type * fix circleCI tests
ESLint API changed so that `node.start/node.end` do not exist anymore.
This makes the lint rule fail opaquely:
```
[13:02:52] AssertionError [ERR_ASSERTION]: Fix has invalid range: {
"range": [
null,
null
],
"text": ""
}
```
These values are now an array `node.range`. Correct errors after fix:
```
build-system/test-configs/forbidden-terms.js
737:7 error File does not exist local/forbidden-terms-config
```
…ct#37420) * set and remove attribute * remove toggle * Use toggleAttribute utility. * Add toggleAttribute to forbidden terms * Refactor toggle attribute.
* extract fn to register custom element * create (empty) amp pbe * inherit amp-accordion from amp-pbe * fix custom-element definitions for iframes (fixes tests) * workarounds to properly test bento components we don't want AMP.BaseElement to be declared so that it won't get injected into the class hierarchy. current tests assume that AMP should be initialized all the time which breaks bento tests * split out generic bento testing from amp tests current (hacky) workarounds: some tests depend on CSS, which we expect consumers to install. This differs from the AMP components that register styles themselves. To workaround this we have to import and append the bento component styles. This problem might be unique to components that don't use shadowCss. For components that do use shadowDom and have critical styling that needs to be tested, those styles are already written in JSS and declared as shadowCss in the bento component's declaration, which ensures that that the styles are baked into the component. * Revert "workarounds to properly test bento components" un-revert in order to test bento component * inherit all non-video bento-amp components from amp-pbe * rename VideoBaseElement -> AmpVideoBaseElement * refactor inheritance hierarchy for video components to remove amp code from bento hierarchy * fix amp-facebook hierarchy to preserve AmpFbBase functionality * update docs to demonstrate new way to scaffold amp-* components * move (some) amp-specific methods into amp-pbe * update dependencies, rename BentoVideoBaseElement * add doc * refactor dailymotion * ampvideobaseelement docs * lint * fix typings and lint * remove file * remove dict() based on ongoign discussions to deprecate * disable local/restrict-this-access for the whole file * remove more references to dict()
# Conflicts: # 3p/vendors/ads2bid.js
auto-merge was automatically disabled
January 21, 2022 14:22
Head branch was pushed to by a user without write access
|
Hey @rsimha! These files were changed: Hey @erwinmombay, @jridgewell! These files were changed: Hey @alanorozco! These files were changed: Hey @danielrozenberg! These files were changed: Hey @rcebulko! These files were changed: Hey @estherkim! These files were changed: Hey @rileyajones! These files were changed: Hey @ampproject/wg-caching! These files were changed: Hey @ampproject/wg-amp4email! These files were changed: Hey @Jiaming-X! These files were changed: Hey @jeffkaufman! These files were changed: Hey @dianomi-cjas! These files were changed: Hey @smart-adserver! These files were changed: Hey @zvalmog! These files were changed: Hey @gmajoulet, @mszylkowski! These files were changed: |
|
@calebcordry thank you! But now we are facing problems. Could you explain the reason? 1. End-to-end test
|
|
Yeah it looks like that didnt quite work as expected. It might be easier to start a new one now, or I can try to walk you through cleaning up the commits? |
|
@calebcordry thanks. We created new MR. Link: #37501 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp-ad ads2bid implementation
cc ampproject/wg-monetization // from docs