Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Guide to Building a Bento Video Player #34195

Merged
merged 19 commits into from
May 4, 2021
Merged

📖 Guide to Building a Bento Video Player #34195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
333340b
📖 Guide to Building a Bento Video Player
alanorozco May 4, 2021
b67e380
links
alanorozco May 4, 2021
068dfef
link/acronym
alanorozco May 4, 2021
7787397
⚠️
alanorozco May 4, 2021
c51e217
wording
alanorozco May 4, 2021
6b3ded6
missing blurb for onMessage
alanorozco May 4, 2021
f022461
codeblock types
alanorozco May 4, 2021
88219dd
details for 'origin'
alanorozco May 4, 2021
de0f286
address review
alanorozco May 4, 2021
dd80d11
slack link
alanorozco May 4, 2021
6f7f08c
assorted changes
alanorozco May 4, 2021
2a6365d
mismatched diff
alanorozco May 4, 2021
25a5587
nit
alanorozco May 4, 2021
09a133f
ref
alanorozco May 4, 2021
bd23e5f
alphabetical order
alanorozco May 4, 2021
155b69c
clearer order
alanorozco May 4, 2021
bd47b62
clearer
alanorozco May 4, 2021
5e0a5d0
fix link
alanorozco May 4, 2021
6b14625
fix link for real
alanorozco May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contributing/building-a-bento-amp-extension.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,8 +670,9 @@ $ amp check-types
- [amp-timeago](https://github.com/ampproject/amphtml/pull/26507)
- [amp-base-carousel](https://github.com/ampproject/amphtml/pull/29303)
- [amp-stream-gallery](https://github.com/ampproject/amphtml/pull/30597)
- Adding video components which use `VideoWrapper`
- Adding video components which use `VideoWrapper`. [You may also follow the guide to Building a Bento Video Component.](./building-a-bento-video-player.md)
alanorozco marked this conversation as resolved.
Show resolved Hide resolved
- [amp-video](https://github.com/ampproject/amphtml/pull/30280)
- [amp-vimeo](https://github.com/ampproject/amphtml/pull/33971)
alanorozco marked this conversation as resolved.
Show resolved Hide resolved
- [amp-youtube](https://github.com/ampproject/amphtml/pull/30444)
- Adding iframe based embeds
- [amp-instagram](https://github.com/ampproject/amphtml/pull/30230)
Loading