📖 Guide to Building a Bento Video Player #34195
Conversation
| allowlist: [ | ||
| ... | ||
| + // Bento MyFantasticPlayer, amp-my-fantastic-player | ||
| + 'extensions/amp-my-fantastic-player/1.0/base-element.js->extensions/amp-video/1.0/base-element.js', |
There was a problem hiding this comment.
Might be worth sectioning off the area of dep-check config that currently has YouTube and Vimeo to establish a video-player section. Also, will Bento components need a dep on the video-manager-impl.js service or is that only for AMP components?
There was a problem hiding this comment.
I would prefer that, but I don't know if we should go against the convention in that file.
| case 'pause': | ||
| dispatchCustomEvent(currentTarget, data.event, null, { | ||
| bubbles: true, | ||
| cancelable: false, |
There was a problem hiding this comment.
Do bubbles/cancelable need to be wrapped in quotes? I have a hard time keeping track
There was a problem hiding this comment.
Per type check, no, since we only want an Object.
This doesn't cause any issues since we don't do advanced compilation, and we cannot do it without singlepass. Does it even matter anymore?
No description provided.