[amp-analytics] More visibilitySpec vars. #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New vars: backgrounded, backgroundedAtLoad, elementX, elementY, elementWidth, elementHeight, totalTime.
| @@ -86,6 +86,9 @@ exports.rules = [ | |||
| { | |||
| filesMatching: 'extensions/**/*.js', | |||
| mustNotDependOn: 'src/service/**/*.js', | |||
| whitelist: [ | |||
| 'extensions/amp-analytics/0.1/visibility-impl.js->src/service/viewer-impl.js' | |||
There was a problem hiding this comment.
Why? This shouldn't be needed.
There was a problem hiding this comment.
Actually this is very dangerous. Let's remove.
| height: br.height}; | ||
| const intersection = rectIntersection(viewportRect, elementRect); | ||
| state[LOAD_TIME_VISIBILITY] = intersection != null | ||
| ? Math.round(intersection.width * intersection.height * 10000 |
There was a problem hiding this comment.
Do we do anything when br.width or br.height are 0?
There was a problem hiding this comment.
This allows for two significant digits after decimal. So 12.344 becomes 12.34 and 12.346 becomes 12.35
Regarding br.width and br.height: I'll need to add checks for that. Currently that would be a problem.
(in practical cases, tracking 0 width/height elements does not make sense.)
|
LGTM |
|
Sorry, a couple late questions on this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New vars: backgrounded, backgroundedAtLoad, elementX, elementY,
elementWidth, elementHeight, totalTime.
#1297