Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Error: Assertion failed #62

Open
ampprojectbot opened this issue Mar 4, 2021 · 1 comment
Open

🚨 Error: Assertion failed #62

ampprojectbot opened this issue Mar 4, 2021 · 1 comment

Comments

@ampprojectbot
Copy link
Member

Details

Error report: link
First seen: Mar 4, 2021
Frequency: ~ 1,974/day

Stacktrace

Error: Assertion failed
    at message (src/core/assert.js:92:29)
    at getElementsByClassName (src/service/owners-impl.js:137:34)
    at getElementsByClassName (src/service/owners-impl.js:137:34)
    at findResourcesInElements_ (src/service/owners-impl.js:95:4)
    at this (extensions/amp-consent/0.1/consent-ui.js:370:8)
    at pause (extensions/amp-consent/0.1/amp-consent.js:171:22)
    at unlayoutCallback (src/custom-element.js:1512:42)
    at disconnect (src/service/resource.js:1124:2)
    at whenSignal (src/utils/signals.js:65:2)
    at VISIBLE (src/visibility-state.js:30:11)
    at PRERENDER (src/visibility-state.js:25:13)
    at src/service/task-queue.js:87:4
    at measure (src/service/resources-impl.js:754:18)
    at Input (src/input.js:32:13)
    at delay (src/pass.js:94:36)
    at this (src/service/timer-impl.js:121:15)

Notes

@rcebulko modified src/core/assert.js:92-93 in #32887 (Feb 25, 2021)
@lannka modified src/service/owners-impl.js:118-155 in #24222 (Aug 30, 2019)
@lannka modified src/service/owners-impl.js:118-155 in #24222 (Aug 30, 2019)
@renovate-bot modified src/service/owners-impl.js:95-95 in #27350 (Mar 30, 2020)
@dvoytenko modified extensions/amp-consent/0.1/consent-ui.js:366-392 in #32480 (Feb 8, 2021)
@dvoytenko modified extensions/amp-consent/0.1/amp-consent.js:168-181 in #32480 (Feb 8, 2021)
@dvoytenko modified src/service/resource.js:1119-1125 in #6575 (Dec 9, 2016)
@dvoytenko modified src/utils/signals.js:57-70 in #7240 (Jan 30, 2017)
@avimehta modified src/visibility-state.js:1-48 in #3371 (Jun 2, 2016)
@avimehta modified src/visibility-state.js:1-48 in #3371 (Jun 2, 2016)
@dvoytenko modified src/service/task-queue.js:43-95 in #3544 (Jun 14, 2016)
@muxin modified src/service/resources-impl.js:751-754 in #7327 (Feb 17, 2017)
@dvoytenko modified src/input.js:27-45 in #226 (Sep 18, 2015)
@cramforce modified src/pass.js:94-94 in #3904 (Jul 6, 2016)
@renovate-bot modified src/service/timer-impl.js:121-121 in #27350 (Mar 30, 2020)

Seen in:

  • 03-04 Nightly (0444)

Possible assignees: @rcebulko, @dvoytenko

/cc @ampproject/release-on-duty

@rcebulko
Copy link
Collaborator

rcebulko commented Mar 4, 2021

As a result of ampproject/amphtml#32828 , devAsserts temporarily made it into Nightly build. They are being removed again (fix in ampproject/amphtml#33087) but this was one assertion which was failing in production. Suggest replacing this devAssert with explicit error report to collect data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants