Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Upgrade colors dependency in NodeJS validator #31656

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

benmccann
Copy link
Contributor

colors 1.2.5 is three years old. Its inclusion is causing the warnings below in my project. This was fixed in 1.3.1 (Marak/colors.js#233)

(!) Circular dependencies
../../node_modules/.pnpm/[email protected]/node_modules/colors/lib/colors.js -> ../../node_modules/.pnpm/[email protected]/node_modules/colors/lib/maps/america.js -> ../../node_modules/.pnpm/[email protected]/node_modules/colors/lib/colors.js
../../node_modules/.pnpm/[email protected]/node_modules/colors/lib/colors.js -> ../../node_modules/.pnpm/[email protected]/node_modules/colors/lib/maps/america.js -> /home/bmccann/src/kit/node_modules/.pnpm/[email protected]/node_modules/colors/lib/colors.js?commonjs-proxy -> ../../node_modules/.pnpm/[email protected]/node_modules/colors/lib/colors.js
../../node_modules/.pnpm/[email protected]/node_modules/colors/lib/colors.js -> ../../node_modules/.pnpm/[email protected]/node_modules/colors/lib/maps/zebra.js -> ../../node_modules/.pnpm/[email protected]/node_modules/colors/lib/colors.js
...and 3 more

@amp-owners-bot
Copy link

amp-owners-bot bot commented Dec 17, 2020

Hey @ampproject/wg-caching! These files were changed:

validator/js/nodejs/package-lock.json
validator/js/nodejs/package.json

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2020

CLA assistant check
All committers have signed the CLA.

@MichaelRybak MichaelRybak self-requested a review December 21, 2020 20:05
@benmccann
Copy link
Contributor Author

@MichaelRybak @honeybadgerdontcare just checking in on this. Is there anything it's waiting for to be merged since it's been approved? Thanks!

@honeybadgerdontcare
Copy link
Contributor

@benmccann It may have been overlooked due to the holidays. Thanks for reminding us!

@honeybadgerdontcare honeybadgerdontcare merged commit b352770 into ampproject:master Jan 6, 2021
@benmccann benmccann deleted the validator-deps branch January 6, 2021 05:48
@honeybadgerdontcare
Copy link
Contributor

This has been released as v.1.0.34
https://www.npmjs.com/package/amphtml-validator/v/1.0.34

@benmccann
Copy link
Contributor Author

thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants