Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies (prevents proper rollup) #233

Closed
danielgindi opened this issue Jul 16, 2018 · 2 comments
Closed

Circular dependencies (prevents proper rollup) #233

danielgindi opened this issue Jul 16, 2018 · 2 comments

Comments

@danielgindi
Copy link

Rollup spits those out:

Circular dependency: node_modules\colors\lib\colors.js -> node_modules\colors\lib\maps\america.js -> node_modules\colors\lib\colors.js
Circular dependency: node_modules\colors\lib\colors.js -> node_modules\colors\lib\maps\america.js ->  commonjs-proxy:C:\Users\Daniel.SILVERBOLT\Desktop\git\endpoint-analyzer\node_modules\colors\lib\colors.js -> node_modules\colors\lib\colors.js
Circular dependency: node_modules\colors\lib\colors.js -> node_modules\colors\lib\maps\zebra.js -> node_modules\colors\lib\colors.js
Circular dependency: node_modules\colors\lib\colors.js -> node_modules\colors\lib\maps\rainbow.js -> node_modules\colors\lib\colors.js
Circular dependency: node_modules\colors\lib\colors.js -> node_modules\colors\lib\maps\random.js -> node_modules\colors\lib\colors.js

It is a huge problem, and will make code unexecutable after "rolling up".
The rollup process will convert commonjs deps into "static imports", which do not support circular dependencies.
Then it will end up with a flat hierarchy where there's a reference to a (yet) undefined variable.

@DABH
Copy link
Contributor

DABH commented Jul 23, 2018

This should be fixed in [email protected]. Let us know if the issues persist. Thanks!

@DABH DABH closed this as completed Jul 23, 2018
@danielgindi
Copy link
Author

Amazing, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants