Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an embed override for timer service #31551

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Use an embed override for timer service #31551

merged 2 commits into from
Dec 10, 2020

Conversation

dvoytenko
Copy link
Contributor

Closes #22733.

@dvoytenko dvoytenko merged commit 35d3569 into ampproject:master Dec 10, 2020
@dvoytenko dvoytenko deleted the run3/timer-embed-service branch December 10, 2020 23:42
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Dec 15, 2020
@Enriqe
Use an embed override for timer service (ampproject#31551)
e75f58e 
* Use an embed override for timer service

* fixed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samouri samouri samouri left review comments

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup ampdoc-fie experiment
4 participants
@dvoytenko @jridgewell @samouri @ampprojectbot