Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ampdoc-fie experiment #22733

Closed
8 tasks done
dvoytenko opened this issue Jun 6, 2019 · 2 comments · Fixed by #31551
Closed
8 tasks done

Cleanup ampdoc-fie experiment #22733

dvoytenko opened this issue Jun 6, 2019 · 2 comments · Fixed by #31551

Comments

@dvoytenko
Copy link
Contributor

dvoytenko commented Jun 6, 2019

See launch in #22734

TODO for cleanup:

  • Remove FriendlyIframeEmbedLegacy
  • FriendlyIframeEmbed make ampdoc non-nullable and update the code accordingly.
  • cleanup ampdoc service lookup
  • Remove EmbeddableService.installInEmbedWindow interface.
  • Remove installServiceInEmbedScope function.
  • Remove opt_win, opt_root, etc arguments from Bind, AmpGwdRuntimeService, HiddenObserver, Action, StandardActions, Navigation, Url, and other embeddable services. (See Introduce ampdoc on a FIE level #22493 for some examples).
  • Remove the getExistingServiceForDocInEmbedScope.
  • Remove the installStylesLegacy.
@zhouyx
Copy link
Contributor

zhouyx commented Jul 2, 2019

cc @ampproject/wg-ads Does this mean that FIE will have its own instance of ampdoc in the future?

@dvoytenko
Copy link
Contributor Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants