-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup ampdoc-fie experiment #22733
Comments
cc @ampproject/wg-ads Does this mean that FIE will have its own instance of ampdoc in the future? |
yes |
This was referenced Aug 7, 2019
This was referenced Sep 20, 2019
This was referenced Oct 1, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See launch in #22734
TODO for cleanup:
FriendlyIframeEmbedLegacy
FriendlyIframeEmbed
makeampdoc
non-nullable and update the code accordingly.EmbeddableService.installInEmbedWindow
interface.installServiceInEmbedScope
function.opt_win
,opt_root
, etc arguments fromBind
,AmpGwdRuntimeService
,HiddenObserver
,Action
,StandardActions
,Navigation
,Url
, and other embeddable services. (See Introduce ampdoc on a FIE level #22493 for some examples).getExistingServiceForDocInEmbedScope
.installStylesLegacy
.The text was updated successfully, but these errors were encountered: