Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support visibility API in the ampdoc #23799

Merged
merged 9 commits into from
Aug 19, 2019
Merged

Conversation

dvoytenko
Copy link
Contributor

@dvoytenko dvoytenko commented Aug 7, 2019

Blocked by #23871.

Partial for #22734, #22733.

Step 1: support visiblityState and family APIs in AmpDoc.
Step 2: remove visibilityState from Viewer.

src/runtime.js Show resolved Hide resolved
src/service/ampdoc-impl.js Show resolved Hide resolved
src/service/ampdoc-impl.js Outdated Show resolved Hide resolved
src/service/ampdoc-impl.js Show resolved Hide resolved
src/service/ampdoc-impl.js Show resolved Hide resolved
src/service/ampdoc-impl.js Show resolved Hide resolved
src/utils/document-visibility.js Show resolved Hide resolved
test/unit/utils/test-document-visibility.js Outdated Show resolved Hide resolved
test/unit/utils/test-document-visibility.js Outdated Show resolved Hide resolved
@dvoytenko dvoytenko merged commit 0c5e03f into ampproject:master Aug 19, 2019
@dvoytenko dvoytenko deleted the ampdoc21 branch August 19, 2019 20:15
westonruter added a commit to westonruter/amphtml that referenced this pull request Aug 20, 2019
* 'master' of github.com:ampproject/amphtml: (32 commits)
  ✨ Make tweet id a bindable attribute (ampproject#23953)
  🏗 Update Local AMP extension to allow custom base URLs (ampproject#24029)
  🏗 Improve serving from non-localhost host (ampproject#24066)
  Preventing half pixels. (ampproject#24050)
  Update callout-vendors.js (ampproject#23218)
  🏗 Fixes to `check-package-manager.js` (ampproject#24060)
  Rename AMP_MODE to __AMP_MODE. (ampproject#24052)
  Story media performance metrics. (ampproject#23962)
  Updating Story amp-sidebar width documentation. (ampproject#23894)
  Fixes race condition in amp-video-iframe (ampproject#24033)
  Rename ampExtendedElements to __AMP_EXTENDED_ELEMENTS (ampproject#24056)
  🏗🚮 Enable property inlining (ampproject#24053)
  ✨amp-ads: Added optional params for Directadvert network (ampproject#23724)
  <amp-experiment> style mutation fix and improvment (ampproject#23669)
  🐛 Allow http protocol for noscript > img fallbacks for parity with amp-img (ampproject#21686)
  🏗 Refactor transform-log-asserts (ampproject#24028)
  Automatically preconnect to source origins on page loads. (ampproject#24045)
  Support visibility API in the ampdoc (ampproject#23799)
  Amphtml visual tests should use relative path against root (ampproject#24042)
  FIX: check all fields' dirtiness on AMP form init (ampproject#23978)
  ...
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
* Support visibility API in the ampdoc

* fixing integr tests

* review fixes

* nits

* fix preconnect

* test fixes

* wip

* test fixes

* test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants