Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 activation-tracker: 'change' is an activation event #27108

Merged
merged 2 commits into from
Mar 5, 2020
Merged

🐛 activation-tracker: 'change' is an activation event #27108

merged 2 commits into from
Mar 5, 2020

Conversation

samouri
Copy link
Member

@samouri samouri commented Mar 5, 2020

Fixes #26960

@samouri samouri self-assigned this Mar 5, 2020
@amp-owners-bot amp-owners-bot bot requested a review from dreamofabear March 5, 2020 16:08
@samouri samouri force-pushed the change-activation branch from 4d9e2d8 to c2360bb Compare March 5, 2020 21:19
@samouri
Copy link
Member Author

samouri commented Mar 5, 2020

rebased to help w percy. 0 chance it was a real failure

@samouri samouri merged commit 4e275ba into ampproject:master Mar 5, 2020
@samouri samouri deleted the change-activation branch March 5, 2020 21:59
@samouri samouri mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees

@samouri samouri

Labels
cla: yes Component: amp-script PR use: In Beta / Experimental PR use: In Stable Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

amp-script overzealously terminates workers
4 participants
@samouri @dreamofabear @googlebot @ampprojectbot