Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: enable chai-as-promised for integ tests #27077

Merged
merged 5 commits into from
Mar 12, 2020
Merged

testing: enable chai-as-promised for integ tests #27077

merged 5 commits into from
Mar 12, 2020

Conversation

samouri
Copy link
Member

@samouri samouri commented Mar 3, 2020 •
edited
Loading

summary
Enables chai-as-promised for integ tests. It does this by including chai-as-promised in babelify transpilation.

todo:

  • remove module test/chai-as-promised/chai-as-promised in favor of directly using chai.use(...) within _init_tests.js
  • add comments to the browserify ignore line.

@samouri samouri force-pushed the enable-promised branch 3 times, most recently from 7f2950e to 2d38ed8 Compare March 10, 2020 15:23
@samouri samouri self-assigned this Mar 10, 2020
@samouri samouri marked this pull request as ready for review March 10, 2020 17:38
@amp-owners-bot
Copy link

Hey @estherkim, these files were changed:

build-system/tasks/runtime-test/runtime-test-base.js

@samouri samouri requested review from estherkim and removed request for rcebulko March 10, 2020 17:40
estherkim
estherkim reviewed Mar 10, 2020
View reviewed changes
Copy link
Collaborator

@estherkim estherkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!!

extensions/amp-bind/0.1/test/integration/test-bind-impl.js Outdated Show resolved Hide resolved
test/_init_tests.js Outdated Show resolved Hide resolved
@samouri samouri merged commit 6b439ae into ampproject:master Mar 12, 2020
@samouri samouri deleted the enable-promised branch March 12, 2020 00:27
@samouri samouri mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherkim estherkim estherkim approved these changes

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees

@samouri samouri

Labels
cla: yes PR use: In Beta / Experimental PR use: In Stable WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samouri @dreamofabear @estherkim @googlebot @ampprojectbot